feat: expose device-based consent APIs in React Native bridge by denischilik · Pull Request #351 · mParticle/react-native-mparticle

denischilik · 2026-06-25T16:47:48Z

Add device-level consent state to React Native bridge

Summary

Exposes device-level consent APIs in the React Native wrapper so apps can set, read, and clear device-scoped consent from JavaScript. Native device consent (added in mParticle Apple SDK and android-core) supersedes per-user/MPID consent when set — consent collected before login or across identity changes at checkout is retained on the device.

Bridges to:

iOS — MParticle.sharedInstance().deviceConsentState (requires mParticle Apple SDK 9.2+ with device consent)
Android — MParticle.getInstance().setDeviceConsentState() / getDeviceConsentState() (requires android-core release with device consent APIs; resolves via [5.79.2, 6.0))

What has changed

Added setDeviceConsentState, clearDeviceConsentState, and getDeviceConsentState to the JS API and default export
Wired TurboModule/codegen spec, Android MParticleModule, and iOS RNMParticle (old arch + new arch)
Reused existing consent map converters on Android; added RCTConvert MPConsentState: and consentStateToDictionary: on iOS

Sample code

import {
  setDeviceConsentState,
  clearDeviceConsentState,
  getDeviceConsentState,
} from 'react-native-mparticle';

// Set device-wide consent (supersedes any per-user consent)
setDeviceConsentState({
  gdpr: {
    data_sharing: {
      consented: true,
      document: 'privacy_policy_v3',
      timestamp: Date.now(),
    },
  },
});

// Clear — reverts to user/MPID-level consent
clearDeviceConsentState();

// Read current device consent
getDeviceConsentState((state) => {
  console.log(state);
});

Testing

./gradlew test and ./gradlew ktlintCheck pass on the Android module

Checklist

I have performed a self-review of my own code.
I have made corresponding changes to the documentation.
I have added tests that prove my fix is effective or that my feature works.
I have tested this locally.

Related Android PR: mParticle/mparticle-android-sdk#726

Related iOS PR: mParticle/mparticle-apple-sdk#784 (merged)

Bridge setDeviceConsentState, clearDeviceConsentState, and getDeviceConsentState to native device consent on iOS and Android.

cursor · 2026-06-25T16:47:55Z

PR Summary

Medium Risk
Changes affect privacy/consent behavior and how timestamps are parsed for GDPR/CCPA; incorrect mapping could mis-report consent, though scope is limited to new device APIs and existing consent converters.

Overview
Adds device-scoped consent to the public JS API via setDeviceConsentState, clearDeviceConsentState, and getDeviceConsentState, wired through the TurboModule spec and native bridges on Android and iOS (old and new architecture). Device consent maps to MParticle device consent on the native SDKs and can override per-user/MPID consent when set.

Introduces a DeviceConsentState type (GDPR purposes + optional CCPA) and shared conversion helpers: Android builds/reads full ConsentState objects and treats empty payloads as clear; iOS adds RCTConvert MPConsentState: and round-trip consentStateToDictionary: for reads.

Consent timestamp handling is tightened on both platforms—Android accepts number or string millis via readConsentTimestampMillis; iOS GDPR/CCPA converters interpret JS timestamps as epoch milliseconds instead of generic NSDate conversion.

^{Reviewed by Cursor Bugbot for commit ab85cc1. Bugbot is set up for automated code reviews on this repo. Configure here.}

Re-export DeviceConsentState from NativeMParticle codegen so getDeviceConsentState callback matches the TurboModule signature.

Device consent RCT_EXPORT_METHODs call MPConsentState: before the RCTConvert category is defined later in the file.

- Move old-arch RCT_EXPORT_METHODs into #else block to avoid duplicate declarations when New Architecture is enabled. - Move consentStateToDictionary onto RNMParticle (was wrongly on RCTConvert). - Use NSDictionary codegen types for new-arch setDeviceConsentState.

Use NSNull in getDeviceConsentState callback when consentStateToDictionary returns nil for an empty MPConsentState.

When gdpr is null or not a map, continue processing ccpa instead of returning null from convertToConsentState.

MPConsentState and RCT_EXPORT consent paths use MPGDPRConsent/ MPCCPAConsent converters that treated JS timestamps as seconds via RCTConvert NSDate. Divide by 1000 to match Date.now() and read path.

Assign nil/null when the converted consent state has no GDPR or CCPA entries, matching clearDeviceConsentState behavior.

cursor

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

There are 3 total unresolved issues (including 2 from previous reviews).

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit a30b9e8. Configure here.}

Read consent timestamps as Number or String on Android so getDeviceConsentState round-trips correctly. Guard iOS MPConsentState conversion against non-dictionary GDPR/CCPA values. Fix new arch setDeviceConsentState by converting codegen structs to NSDictionary before RCTConvert.

Codegen exposes DeviceConsentState.gdpr() as id, not std::optional, so setDeviceConsentState must not call has_value/value on it.

feat: expose device-based consent APIs in React Native bridge

ceaee42

Bridge setDeviceConsentState, clearDeviceConsentState, and getDeviceConsentState to native device consent on iOS and Android.

denischilik requested a review from a team as a code owner June 25, 2026 16:47

samdozor reviewed Jun 25, 2026

View reviewed changes

Comment thread android/src/main/java/com/mparticle/react/MParticleModule.kt Outdated

cursor Bot reviewed Jun 25, 2026

View reviewed changes

Comment thread ios/RNMParticle/RNMParticle.mm Outdated

Comment thread android/src/main/java/com/mparticle/react/MParticleModule.kt Outdated

denischilik added 4 commits June 25, 2026 14:03

fix: align DeviceConsentState type with codegen spec

31dc392

Re-export DeviceConsentState from NativeMParticle codegen so getDeviceConsentState callback matches the TurboModule signature.

fix(ios): forward-declare RCTConvert MPConsentState for old arch

1290eb1

Device consent RCT_EXPORT_METHODs call MPConsentState: before the RCTConvert category is defined later in the file.

fix(ios): avoid NSInvalidArgumentException on empty device consent

315591d

Use NSNull in getDeviceConsentState callback when consentStateToDictionary returns nil for an empty MPConsentState.

cursor Bot reviewed Jun 25, 2026

View reviewed changes

Comment thread ios/RNMParticle/RNMParticle.mm

Comment thread android/src/main/java/com/mparticle/react/MParticleModule.kt

Comment thread android/src/main/java/com/mparticle/react/MParticleModule.kt

denischilik added 3 commits June 25, 2026 15:31

fix(android): skip invalid GDPR map without dropping CCPA

f684e60

When gdpr is null or not a map, continue processing ccpa instead of returning null from convertToConsentState.

fix(ios): parse consent timestamps as milliseconds

a30b9e8

MPConsentState and RCT_EXPORT consent paths use MPGDPRConsent/ MPCCPAConsent converters that treated JS timestamps as seconds via RCTConvert NSDate. Divide by 1000 to match Date.now() and read path.

fix: treat empty setDeviceConsentState as clear on iOS and Android

25d1351

Assign nil/null when the converted consent state has no GDPR or CCPA entries, matching clearDeviceConsentState behavior.

cursor Bot reviewed Jun 25, 2026

View reviewed changes

Comment thread ios/RNMParticle/RNMParticle.mm

denischilik added 2 commits June 25, 2026 15:53

fix(ios): treat gdpr as NSDictionary in new arch device consent

ab85cc1

Codegen exposes DeviceConsentState.gdpr() as id, not std::optional, so setDeviceConsentState must not call has_value/value on it.

denischilik requested review from BrandonStalnaker and samdozor June 25, 2026 20:38

BrandonStalnaker approved these changes Jun 25, 2026

View reviewed changes

denischilik merged commit 72235e0 into main Jun 25, 2026
11 checks passed

denischilik deleted the feat/device-based-consent branch June 25, 2026 21:06

rokt-releases Bot mentioned this pull request Jun 25, 2026

chore: release 3.2.0 #352

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: expose device-based consent APIs in React Native bridge#351

feat: expose device-based consent APIs in React Native bridge#351
denischilik merged 10 commits into
mainfrom
feat/device-based-consent

denischilik commented Jun 25, 2026

Uh oh!

cursor Bot commented Jun 25, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

denischilik commented Jun 25, 2026

Add device-level consent state to React Native bridge

Summary

What has changed

Sample code

Testing

Checklist

Uh oh!

cursor Bot commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cursor Bot commented Jun 25, 2026 •

edited

Loading